]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
a11y: Don't create a parent loop for quick settings sliders
authorLukáš Tyrychtr <ltyrycht@redhat.com>
Thu, 11 May 2023 09:19:36 +0000 (11:19 +0200)
committerFlorian Müllner <fmuellner@gnome.org>
Thu, 13 Jul 2023 16:15:16 +0000 (18:15 +0200)
Rather than returning the parent container of the slider, which presents
itself as the slider, return the parent of the slider container.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6686

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2762>

js/ui/quickSettings.js

index 7f08d6f7541ccbd86d07f2c8690be6f942d4fa90..9016fedf6f2802075854e89bb9a6c64fb3e3c11c 100644 (file)
@@ -323,7 +323,10 @@ var QuickSlider = GObject.registerClass({
         });
         box.add_child(sliderBin);
 
-        sliderBin.set_accessible(this.slider.get_accessible());
+        // Make the slider bin transparent for a11y
+        const sliderAccessible = this.slider.get_accessible();
+        sliderAccessible.set_parent(sliderBin.get_parent().get_accessible());
+        sliderBin.set_accessible(sliderAccessible);
         sliderBin.connect('event', (bin, event) => this.slider.event(event, false));
 
         this._menuButton = new St.Button({